feat: introduce crate_attrs field in rust-project.json
#21282
Merged
+473
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
I deliberately excluded lint attribute support in this PR, since it would involve a change to the public API. It might deserve a dedicated PR for discussion, since I'm not yet sure it's worth pursuing. Please let me know if anyone thinks this is the better place for it. |
Contributor
|
We don't hesitate too much before breaking our public API (it's explicitly not stable), especially an API like that that is basically directly intended at its single consumer. |
Contributor
Author
I see, thanks! Then I'll add it here. |
J3m3
commented
Dec 16, 2025
ChayimFriedman2
requested changes
Dec 16, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Left some comments.
J3m3
commented
Dec 17, 2025
ChayimFriedman2
requested changes
Dec 17, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Just one nit, then LGTM.
J3m3
force-pushed
the
crate-attrs
branch
2 times, most recently
from
4fd0e6e to
5b01d68
Compare
Since the commit 5038446 ("Rewrite method resolution to follow rustc more closely"), the method resolution logic has changed: rust-analyzer only looks up inherent methods for primitive types in sysroot crates. Unfortunately, this change broke at least one project that relies on `rust-project.json`: Rust-for-Linux. Its auto-generated `rust-project.json` directly embeds `core`, `alloc`, and `std` in the `crates` list without defining `sysroot_src`. Consequently, rust-analyzer fails to identify them as sysroot crates, breaking IDE support for primitive methods (e.g., `0_i32.rotate_left(0)`). However, specifying `sysroot_src` creates a new issue: it implicitly adds `std` as a dependency to all kernel module crates, which are actually compiled with `-Zcrate-attr=no_std`. Since rust-analyzer cannot see compiler flags passed outside of the project definition, we need a method to explicitly specify `#![no_std]` or, more generally, crate-level attributes through the project configuration. To resolve this, extend the `rust-project.json` format with a new `crate_attrs` field. This allows users to specify crate-level attributes such as `#![no_std]` directly into the configuration, enabling rust-analyzer to respect them when analyzing crates. References: - The original Zulip discussion: https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Primitive.20type.20inherent.20method.20lookup.20fails/with/562983853
Contributor
Author
|
Sorry for the noise 😂 I've only changed the tests you mentioned. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the commit 5038446
("Rewrite method resolution to follow rustc more closely"), the method resolution logic has changed: rust-analyzer only looks up inherent methods for primitive types in sysroot crates.
Unfortunately, this change broke at least one project that relies on
rust-project.json: Rust-for-Linux. Its auto-generatedrust-project.jsondirectly embedscore,alloc, andstdin thecrateslist without definingsysroot_src. Consequently, rust-analyzer fails to identify them as sysroot crates, breaking IDE support for primitive methods (e.g.,0_i32.rotate_left(0)).However, specifying
sysroot_srccreates a new issue: it implicitly addsstdas a dependency to all kernel module crates, which are actually compiled with-Zcrate-attr=no_std. Since rust-analyzer cannot see compiler flags passed outside of the project definition, we need a method to explicitly specify#![no_std]or, more generally, crate-level attributes through the project configuration.To resolve this, extend the
rust-project.jsonformat with a newcrate_attrsfield. This allows users to specify crate-level attributes such as#![no_std]directly into the configuration, enabling rust-analyzer to respect them when analyzing crates.References: