links old version of cf{g,s}et{i,o}speed for glibc #4882
+517
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
S-waiting-on-review
stable-nominated
tgross35
reviewed
Dec 17, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Since we aren't able to test the function pointers, would it be possible to add an integration test in https://github.com/rust-lang/libc/tree/main/libc-test/tests? Something simple to verify we link correctly and that our baud constants work.
It's unfortunate that we need as much cfg as we do here, but this fix is much needed. Thank you for putting this together!
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
usamoi
force-pushed
the
baud
branch
2 times, most recently
from
dd7a939 to
294e97c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
usamoi
force-pushed
the
baud
branch
4 times, most recently
from
44149d2 to
676fbe7
Compare
Author
|
@rustbot ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes#4692.Sources
https://github.com/bminor/glibc
cfsetspeed
cfsetispeed
cfsetospeed
cfgetispeed
cfgetospeed
@rustbot label stable-nominated