Improved docstrings for free::chain
#634
Conversation
src/free.rs
Outdated
| } | ||
|
|
||
| /// Create an iterator that first iterates `i` and then `j`. | ||
| /// `chain()` returns the result of combining the _first_ |
There was a problem hiding this comment.
fix: As in #633 (comment), this is not just about https://doc.rust-lang.org/nightly/std/primitive.array.htmls, so shouldn't be written this way.
|
@scottmcm: std::iter::chain this means that this function was also stabilized in std, right? |
phimuemue
left a comment
phimuemue
left a comment
There was a problem hiding this comment.
Hi there, thanks for this - improvements to documentation is always good!
It would be nice if you could incorporate the suggestions (or refute them with good reason), and sqash your changes into a single commit.
JoelMon
force-pushed
the
chain-docstring
branch
2 times, most recently
from
94326f3 to
860f239
Compare
|
I think I finally got this git squashing, force pushing stuff down. It's about time. 😆 |
phimuemue
left a comment
phimuemue
left a comment
There was a problem hiding this comment.
Thanks for the changes. Could you have a second look there? With the suggested changes, I think we're good to go.
JoelMon
force-pushed
the
chain-docstring
branch
from
860f239 to
520765c
Compare
|
@phimuemue, would you be able to take a look at #633 as well? |
|
Thanks a bunch! bors r+ |
|
Build succeeded: |
4 participants
Improved the description of the function and added example.