Skip to content

Conversation

@JoelMon
Copy link
Contributor

@JoelMon JoelMon commented Jul 8, 2022

Added body to the code example in the docs for free::zip. The code body added uses two types to make it obvious how zip functions.

Added body to the code example in the docs for free::zip.
The code body added uses two types to make it obvious how `zip`
functions.
@JoelMon JoelMon changed the title Added body to free::zip Added body to free::zip's doc example Jul 8, 2022
@phimuemue
Copy link
Member

Hi there, thank you. I think we'd be willing to accept this, but could you undo all the formatting changes? (It may break other PRs and makes the review difficult.)

@JoelMon
Copy link
Contributor Author

JoelMon commented Jul 9, 2022

Hi there, thank you. I think we'd be willing to accept this, but could you undo all the formatting changes? (It may break other PRs and makes the review difficult.)

Sure, I'll resubmit soon.

BTW, would changes to the other examples in the docstrings of this nature be welcomed?

@phimuemue
Copy link
Member

phimuemue commented Jul 10, 2022

Thanks. If documentation is unclear or inconsistent, improvements are highly welcome.

bors r+ squash

@bors
Copy link
Contributor

bors bot commented Jul 10, 2022

Build succeeded:

@bors bors bot merged commit 7a27408 into rust-itertools:master Jul 10, 2022
@JoelMon JoelMon deleted the zip_docstring branch July 11, 2022 13:14
@jswrenn jswrenn added this to the 0.10.4 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants