bitreq: Remove unused tokio features #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async example did not compile without enabling tokio features that are not used in the rest of the crate. Use a minimal tokio runtime in the example to fix the problem.
jamillambert
force-pushed
the
1125-bitreq-tokio-features
branch
from
33ba79c to
61518d5
Compare
tcharding
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tokio features that are not used in the crate, or only used in an example.
Update the example so that it doesn't require any additional tokio features that the rest of the crate doesn't use.
Remove the unused tokio features. Addresses one of the points in #402.
Update the lock files.