Skip to content

Conversation

@aliebl
Copy link
Contributor

@aliebl aliebl commented Dec 5, 2025

These functions all exist in other plugins, but they lacked some functionality that I was looking for.
So I decided to create a plugin to add what I thought was missing and bundle them together.

Track Drops/Monster Information/Gearing Assistance

Equipment overlay for gearing
NPC HP overlay
NPC Respawn location/time/notification
Loot rarity information sourced from the Wiki
Loot tracker logging specific kill count/date/GE price

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 5, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 7, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Dec 11, 2025

You can't use httpurlconnection directly. Any networking has to be done through @Injecting and using runelite's OkHttpClient.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 11, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 12, 2025
@riktenx
Copy link
Member

riktenx commented Dec 15, 2025

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 15, 2025
Remove unused import and ability to input NPC ids
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 16, 2025
@riktenx
Copy link
Member

riktenx commented Dec 20, 2025

so if you're going to scrape the wiki-- you can actually append ?action=raw (like so - https://oldschool.runescape.wiki/w/Meaty_Aura_Logist?action=raw) and then just do basic string manipulation ops to scrape instead of having to bring in the jsoup dependency. if you are willing to do that and remove the jsoup dependency entirely this will make things a lot easier for me to review which means your plugin gets onto the hub sooner

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 20, 2025
@riktenx
Copy link
Member

riktenx commented Dec 20, 2025

also if you have "borrowed" code from other plugins as your description suggests then please make sure you include the appropriate licenses / attribution in the source code

@aliebl
Copy link
Contributor Author

aliebl commented Dec 23, 2025

Apologies for the complicated review I've sent your way, this is my first plugin so learning the process as I go.

I've updated the code locally to remove the jsoup dependency in the next commit.

Do you have a recommended way to attribute source code? I figured that having the attribution in the README would be sufficient as I didn't use 1 for 1 of the source code, but modified it or used as reference on how to interact with the RuneLite API.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 23, 2025
@riktenx
Copy link
Member

riktenx commented Dec 23, 2025

include any copyright headers present in the original source

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 23, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 23, 2025
@riktenx
Copy link
Member

riktenx commented Dec 27, 2025

You're not removing all of your overlays on shutdown.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2025
Updated to remove overlay on shutdown
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 28, 2025
@riktenx riktenx merged commit 0659b71 into runelite:master Dec 28, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants