-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Create boss-buddy #9744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create boss-buddy #9744
Conversation
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
You can't use httpurlconnection directly. Any networking has to be done through |
|
Remove unused import and ability to input NPC ids
|
so if you're going to scrape the wiki-- you can actually append |
|
also if you have "borrowed" code from other plugins as your description suggests then please make sure you include the appropriate licenses / attribution in the source code |
|
Apologies for the complicated review I've sent your way, this is my first plugin so learning the process as I go. I've updated the code locally to remove the jsoup dependency in the next commit. Do you have a recommended way to attribute source code? I figured that having the attribution in the README would be sufficient as I didn't use 1 for 1 of the source code, but modified it or used as reference on how to interact with the RuneLite API. |
|
include any copyright headers present in the original source |
|
You're not removing all of your overlays on shutdown. |
Updated to remove overlay on shutdown
These functions all exist in other plugins, but they lacked some functionality that I was looking for.
So I decided to create a plugin to add what I thought was missing and bundle them together.
Track Drops/Monster Information/Gearing Assistance
Equipment overlay for gearing
NPC HP overlay
NPC Respawn location/time/notification
Loot rarity information sourced from the Wiki
Loot tracker logging specific kill count/date/GE price