Errors configuring & building RR: Fixes to CMake #4034
Merged
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If RR is to be built by a consuming application, PROJECT_SOURCE_DIR points to actual directory where sources are. Additionally, we also need to properly quote paths (used by both PROJECT_SOURCE_DIR and CMAKE_SOURCE_DIR). If there's a directory with spaces in it, rr builds will break.
theIDinside
force-pushed
the
fix-cmake-file
branch
from
6b3d9c8 to
abfd41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of PROJECT_SOURCE_DIR instead of CMAKE_SOURCE_DIR. If RR is to be built by a consuming application, PROJECT_SOURCE_DIR points to actual directory where sources are (so, CMAKE_SOURCE_DIR shouldn't really be used afaict).
Additionally, we also need to properly quote paths (used by both PROJECT_SOURCE_DIR and CMAKE_SOURCE_DIR). If there's a directory with spaces in it, rr will not configure or build.