Skip to content

feat: add missing event "clippingviewport" #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roerohan merged 1 commit into from
Apr 24, 2025
Merged

feat: add missing event "clippingviewport" #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ interface Props {
onBell?: EventListeners['bell'];
onDesktopName?: EventListeners['desktopname'];
onCapabilities?: EventListeners['capabilities'];
onClippingViewport?: EventListeners['clippingviewport'];
}

// The types NoVncOptions, NoVncEventType and NoVncEvents are from the
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"dependencies": {
"@novnc/novnc": "^1.5.0",
"@types/novnc__novnc": "^1.5.0",
"@types/novnc__novnc": "^1.6.0",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"web-vitals": "^4.2.4"
Expand Down
3 changes: 3 additions & 0 deletions src/lib/VncScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export interface Props {
onBell?: EventListeners['bell'];
onDesktopName?: EventListeners['desktopname'];
onCapabilities?: EventListeners['capabilities'];
onClippingViewport?: EventListeners['clippingviewport'];
}

export type VncScreenHandle = {
Expand Down Expand Up @@ -89,6 +90,7 @@ const VncScreen: React.ForwardRefRenderFunction<VncScreenHandle, Props> = (props
onBell,
onDesktopName,
onCapabilities,
onClippingViewport,
} = props;

const logger = {
Expand Down Expand Up @@ -227,6 +229,7 @@ const VncScreen: React.ForwardRefRenderFunction<VncScreenHandle, Props> = (props
eventListeners.current.bell = onBell;
eventListeners.current.desktopname = _onDesktopName;
eventListeners.current.capabilities = onCapabilities;
eventListeners.current.clippingviewport = onClippingViewport;

(Object.keys(eventListeners.current) as (NoVncEventType)[]).forEach((event) => {
if (eventListeners.current[event]) {
Expand Down