Skip to content

fix: refocus canvas to pick up keystrokes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arctan95 wants to merge 1 commit into from
Closed

fix: refocus canvas to pick up keystrokes #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/lib/VncScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,16 @@ const VncScreen: React.ForwardRefRenderFunction<VncScreenHandle, Props> = (props
connected.current = state;
};

const refocusCanvasOnCaptureElem = () => {
const canvas = document.querySelector('canvas');
Copy link
Owner

@roerohan roerohan Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's another canvas on the page before the noVNC canvas, this line will select that won't it?

Maybe we could do something like

const canvases = Array.from(document.querySelectorAll('canvas'));
const canvas = canvases.filter(({ id }) => id === 'noVNC_mouse_capture_elem');

By the way, have you tested this approach? It does feel a little hacky, but since a lot of people have been facing it I'm happy to merge it (provided it doesn't break anything of course 😅)

canvas?.addEventListener('mouseleave', (e: MouseEvent) => {
const toElement = e.relatedTarget as HTMLElement | null;
if (toElement && toElement.id === 'noVNC_mouse_capture_elem') {
canvas.focus();
}
});
};

const _onConnect = (e: NoVncEvents['connect']) => {
if (onConnect) {
onConnect(e);
Expand Down Expand Up @@ -235,6 +245,7 @@ const VncScreen: React.ForwardRefRenderFunction<VncScreenHandle, Props> = (props
});

setConnected(true);
refocusCanvasOnCaptureElem();
} catch (err) {
logger.error(err);
}
Expand Down