-
Notifications
You must be signed in to change notification settings - Fork 3
Usability fixes #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjamintran1
wants to merge
177
commits into
rockCityMath:main
Choose a base branch
from
Jonathon-Doran:usability-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Usability fixes #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resizing an image, the resize will be limited to being at least 1/8th of the original size. This is to prevent resizes where the images are too small to be interactable or viewable.
This should allow for one to automatically get scrollbars when content exceeds the visible area. Adjustments to the size hint functions because I thought the size was really small.
Included hyperlink, table, undo, and redo buttons
"Section" and "page" are reversed on Opennote compared to Onenote, so for the sake of clarity i swapped the text visually. This is a bandage for the issue.
This reverts commit 9e8ec6f.
Pages used to be able to be nested under other pages.
Not sure if working but it should grab the sections of two pages and merge them into 1 page.
Create add notebook function which asks user to enter note name and create new notebook
Create add notebook function which asks user to enter note name and create new notebook
Now you can create a table with a custom size. No error handling done yet
italics currently selects all containers and italicize
Added functionality to: -bold -underline -italics
toolbar bullet points icon and italics functionality
Added and included functionality to these things from toolbar: - background color - textbox color - font size - font family refactored right click context menu to use Change___Event functions.
- Bullet list now uses signals - fixed background color connecting to all draggable containers - made draggable containers only pass to child if it is in focus - added comments in draggablecontainer.py with explanations on how to connect signals. - includes descriptions on toolbar functions in textbox
- clicking on textbox will immediately focus on textbox and put text cursor at mouse location - selecting from one textbox and selecting from a different textbox will now deselect from the previous textbox
Can now change the page's text color through the right click context menu
Prompt user to enter notebook name and set notebook name on side bar
Signals made from editor to notify when the editor clicks anywhere that's not the currently in focus textbox. -new bug, font family and font size do not work
Just a change from "Page" to "Notebook"
- Removed clearSelectionSlot because it works the same as deselectText()
- When a textbox widget goes beyond it's current size, it will expand by one row. - textbox widget default size now is closer to the size oneNote uses
- fixed typo - removed experimental changes with focusOutEvent - fixing changes from refactoring
Refactor branch
Added comments to various pages to better understand the code.
Updated documentation
Update BuildUI.py
- File and Plugin have are now toolbars instead of menus - all toolbars have moved to being inside a tabbar as per request of sponsor
Bullet points apply individually. Does not work with multiselect but will not apply to every textbox
- upon generating images, textboxes, and tables the widget will be placed where the mouse last clicked. If there is no last click, then default to center of screen. bug: table if attempting to go to center of screen will fail to be created - bugfix: link works again and now checks if https is at the front. - link, date, time resized upon creation - selection background color and selection color is set to be transparent - temp solution: align text, background colors, and bullet points were applying to every textbox so the older code that worked was brought back. - bugfix: link pop up window and table pop up window no longer close upon clicking on something thats not a text field or button - bugfix: width of textbox will no longer go back to 150 if the size was adjusted - bugfix: pressing tab on an empty widget will properly tab issue: if tabbing at the end of a line it will tab out of view rather moving to the next line
- pushed the uncommented self.setWindowFlags(Qt.WindowType.FramelessWindowHint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.