Use checkboxes for preferences and store in sessionStorage #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 8, 2021 00:14
…oad, but not on page close
calebknoll
commented
Aug 8, 2021
|
|
||
| document.getElementById('color').addEventListener('click', function() { | ||
|
|
||
| const colorScale = d3.scaleOrdinal() |
Author
There was a problem hiding this comment.
The bodies of these functions were refactored into a helper function, which makes it look like more change than it really is.
Owner
|
I really regret not merging this at the time. I think it's got some merge conflicts, but I'm on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionStorage is used instead of localStorage as demos usually start with no arrangement, which can be achieved by opening a new tab.