Fixed incorrect dwMaxFileCount value for SFileCreateArchive #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, took alittle awhile to find out why MPQs had an additional 8mb of garbage data at the end of them compared to Ladik's editor. I thought maybe there was a more siginificant fault related to writing the MPQ. In was just a result of SFileCreateArchive in Stormsharplib always passing int.MaxValue even if you provided your own count. This fix address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, took alittle awhile to find out why MPQs had an additional 8mb of
garbage data at the end of them compared to Ladik's editor. I thought
maybe there was a more siginificant fault related to writing the MPQ. In
was just a result of SFileCreateArchive in Stormsharplib always passing
int.MaxValue even if you provided your own count.
This fix address this.
Special thanks to Sundays for walking me through some of the MPQ format stuff to help narrow down the scope of what could be causing this massive chunk of garbage data.