Skip to content

fix: process_video silent hang on callback error #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realh4m wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: process_video silent hang on callback error #2022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion supervision/utils/video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,22 +302,37 @@ def writer_thread(video_sink: VideoSink) -> None:
desc=progress_message,
)

exception_in_worker: Exception | None = None
read_finished = False

try:
while True:
read_item = frame_read_queue.get()
if read_item is None:
read_finished = True
break

frame_index, frame = read_item
processed_frame = callback(frame, frame_index)
try:
processed_frame = callback(frame, frame_index)
except Exception as exc:
exception_in_worker = exc
break

frame_write_queue.put(processed_frame)
progress_bar.update(1)
finally:
frame_write_queue.put(None)
if not read_finished:
while True:
read_item = frame_read_queue.get()
if read_item is None:
break
reader_worker.join()
writer_worker.join()
progress_bar.close()
if exception_in_worker is not None:
raise exception_in_worker


class FPSMonitor:
Expand Down