Skip to content

refactor: streamline QuickStart example with 0.1.2 changes #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfazekas merged 1 commit into from
Dec 18, 2025
Merged

refactor: streamline QuickStart example with 0.1.2 changes #93

mfazekas merged 1 commit into from
Dec 18, 2025

Conversation

@mfazekas
Copy link
Collaborator

@mfazekas mfazekas commented Dec 18, 2025 •
edited
Loading

  • Use useViewModelInstance(riveViewRef) instead of manual useMemo
  • Use onInit callback for initial health value instead of useEffect
  • Use functional updater setHealth((h) => (h ?? 0) - 7) in handleTakeDamage

@mfazekas mfazekas force-pushed the mfazekas/streamline-quickstart branch from 8e50a37 to 6b30587 Compare December 18, 2025 07:30
@mfazekas mfazekas force-pushed the mfazekas/streamline-quickstart branch from 6b30587 to c39c352 Compare December 18, 2025 08:30
@mfazekas mfazekas changed the title refactor: streamline QuickStart example refactor: streamline QuickStart example with 0.1.2 changes Dec 18, 2025
@mfazekas mfazekas marked this pull request as ready for review December 18, 2025 08:32
@mfazekas mfazekas enabled auto-merge (squash) December 18, 2025 08:33
@mfazekas mfazekas requested a review from HayesGordon December 18, 2025 08:34
HayesGordon
HayesGordon approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfazekas mfazekas merged commit 6052279 into main Dec 18, 2025
7 checks passed
@mfazekas mfazekas deleted the mfazekas/streamline-quickstart branch December 18, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HayesGordon HayesGordon HayesGordon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfazekas @HayesGordon