Skip to content

Conversation

@ericokuma
Copy link
Contributor

This PR addresses APP-668 by updating the Add guest users modal:

  • Preselects the first project: If the organization has at least one project, the first project in the list is now preselected by default when the modal opens. This improves user experience by providing a sensible default.
  • Keeps project access multi-select dropdown open: The project selection dropdown now remains open after selecting or deselecting options, allowing users to make multiple selections without re-opening the dropdown each time. This was achieved by switching to onCheckedChange for the dropdown items.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes (APP-668)
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Linear Issue: APP-668

Open in Cursor Open in Web

Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@cursor
Copy link

cursor bot commented Dec 23, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

cursoragent and others added 2 commits December 23, 2025 01:15
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@ericokuma ericokuma requested review from AdityaHegde and lovincyrus and removed request for lovincyrus December 23, 2025 01:26
@ericokuma ericokuma marked this pull request as ready for review December 23, 2025 01:27
@cursor
Copy link

cursor bot commented Dec 23, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 25.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but the inputs seem mismatched. The email input is larger than project and access level.
Screenshot 2025-12-23 at 10 58 13 AM

Also there is no check mark beside selection in access level. Lets do a follow up to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants