This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Timeout validation remove #453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hmm.. cannot reproduce test failure on maven build... set jdk 13 |
Contributor
Author
|
Well, I opened hashicorp/consul#10945 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm trully sorry for introducing this feature in a first place. It had fixed our issues fast.
But when we looked closely - the problem wasn't in the client at all, so TimeoutInterceptor contains all the required logic to deal with timeouts and does not require validation
So we removed this code in our fork
And I suggest you to drop it too - It makes code uglier
Also, without this code it will be easier to merge code between our distributions)