Update logic to reject participants after redirecting to the training failed page #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of 57c1257 is uploaded and can be seen here: ✨ https://revisit.dev/study/PR989 ✨ Changes may take a few minutes to propagate. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #922
Give a longer description of what this PR addresses and why it's needed
This update prevents rejected participants from continuing the study, even if they attempt to refresh or navigate away during the redirect process.
Previously, when a participant failed training, the rejection was pushed to the storage engine before redirecting to the training failed page. During that 5 second redirects, participants could refresh the page and continue the study.
Are there any additional TODOs before this PR is ready to go?
TODOs: