Skip to content

Enhance PayPal integration to support dynamic currency selection and fix hardcoded "test" client-id #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiragpatel2595 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance PayPal integration to support dynamic currency selection and fix hardcoded "test" client-id #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/payment/default.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% put scripts %}
{% for method in paymentMethods %}
{{ method.renderPaymentScripts()|raw }}
{{ method.renderPaymentScripts(invoice.currency ?invoice.currency.code : 'USD')|raw }}
{% endfor %}
{% endput %}
{% if invoice %}
Expand Down
15 changes: 12 additions & 3 deletions paymenttypes/PayPalPayment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,21 @@ public function getInvoiceCaptureUrl()
/**
* getPayPalEndpoint
*/
public function getPayPalEndpoint()
public function getPayPalEndpoint(): string
{
return $this->getHostObject()->test_mode
? 'https://api-m.sandbox.paypal.com'
: 'https://api-m.paypal.com';
}

/**
* getPayPalClientId
*/
public function getPayPalClientId(): string
{
return $this->getHostObject()->test_mode ? 'test' : $this->getHostObject()->client_id;
}

/**
* getPayPalNamespace
*/
Expand All @@ -110,13 +118,14 @@ public function getPayPalNamespace(): string
/**
* renderPaymentScripts
*/
public function renderPaymentScripts()
public function renderPaymentScripts($currency = 'USD')
{
$queryParams = http_build_query([
'client-id' => 'test',
'client-id' => $this->getPayPalClientId(),
'components' => 'buttons',
'enable-funding' => 'venmo',
'disable-funding' => 'paylater,card',
'currency' => $currency,
]);

$scriptParams = [
Expand Down