-
Notifications
You must be signed in to change notification settings - Fork 201
Update ES translations #109
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update modifies several localization JSON files across multiple languages. The changes include reordering keys within objects, adding newlines at the end of files, introducing new translation keys in the Spanish file, and changing the data structure of a specific help text entry in the English file. No exported or public entities were altered. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant LocalizationFile
User->>App: Selects language or triggers UI needing translation
App->>LocalizationFile: Loads relevant JSON localization file
LocalizationFile-->>App: Provides translation keys/values (with new order, structure, or added keys)
App-->>User: Displays updated UI labels and help texts
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
it/all.json (1)
448-456: No functional impact – LGTMThe change is limited to re-ordering the
"LABEL"entry within theWIKIMEDIA_COMMONSobject.
JSON key order is insignificant at runtime, so there’s no behavioural change. ✅
If reducing diff-noise is a goal, consider keeping keys alphabetically sorted across locale files in future PRs.es/all.json (1)
710-712: Minor wording issue – use “Pegar” instead of “Copiar”The action is to paste a URL, not copy it.
- "PASTE_URL": "Copiar URL de Youtube, PDF o Página Web", + "PASTE_URL": "Pegar URL de YouTube, PDF o página web",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
cn/all.json(2 hunks)de/all.json(2 hunks)en/all.json(1 hunks)es/all.json(5 hunks)fa/all.json(1 hunks)fr/all.json(1 hunks)it/all.json(2 hunks)ja/all.json(2 hunks)ka/all.json(1 hunks)ne/all.json(1 hunks)nl/all.json(1 hunks)pl/all.json(2 hunks)pt-br/all.json(2 hunks)ru/all.json(2 hunks)tr/all.json(1 hunks)vi/all.json(1 hunks)
🔇 Additional comments (19)
ne/all.json (1)
391-392: Consistent trailing newline — LGTMAdding a trailing newline is POSIX-friendly and eliminates diff churn when other tools expect it. No action needed.
nl/all.json (1)
87-88: Consistent trailing newline — LGTMThe added newline aligns this file with common tooling expectations; nothing further.
ka/all.json (1)
42-43: Consistent trailing newline — LGTMThe newline at EOF is a harmless formatting improvement; all good.
fr/all.json (1)
583-584: Consistent trailing newline — LGTMGood to see the newline added for consistency across localisation files.
tr/all.json (1)
484-485: Consistent trailing newline — LGTMEOF newline keeps diffs clean and satisfies linters; no issues.
vi/all.json (1)
262-262: Trailing newline addition looks goodAdding a final newline satisfies POSIX conventions and avoids ‘No newline at end of file’ warnings. No further action required.
ru/all.json (1)
683-683: Key-order tweak is harmless and improves consistencyMoving
"LABEL"to the top of theWIKIMEDIA_COMMONSblock doesn’t affect runtime behaviour but aligns ordering across locale files, making cross-diffs easier to scan. File still contains only one"LABEL"key, so the JSON remains valid.pl/all.json (1)
733-733: Consistent key ordering – looks goodSame reordering as other locales; no duplicate keys introduced. 👍
ja/all.json (1)
716-716: Key moved for uniformity – accepted
"LABEL"now leads theWIKIMEDIA_COMMONSsection, matching other language files. Change is purely cosmetic and safe.fa/all.json (1)
638-645: Key re-ordering only – looks good
"LABEL"was moved ahead of"INVALID"in theWIKIMEDIA_COMMONSblock.
Content and placeholders remain intact, so no issues found.cn/all.json (1)
731-739: LGTMThe only modification is the position of the
"LABEL"key; translation string and placeholders unchanged.
No further action required.pt-br/all.json (1)
725-733: Re-ordering acknowledged – fine to mergeMoving
"LABEL"to the first position has no runtime consequence and keeps consistency with other locales.
All placeholders remain valid.de/all.json (1)
719-719: No functional impact – entry order tweak looks goodMoving the
LABELkey to the top of the section does not change runtime behaviour and keeps the value intact.en/all.json (1)
773-775: No array-stylePROPERTIES_HELP_TEXTusages detected – change is safeA repository-wide scan for
PROPERTIES_HELP_TEXT(andTEMPLATES.PROPERTIES_HELP_TEXT) only returned entries in the translation JSONs, with no code referencing or iterating over it. You can merge this change as-is.es/all.json (5)
16-16: Updated wording LGTM“Flashcards con IA” reads naturally and matches common Spanish phrasing.
700-702: Mobile label addition looks correct
"LABEL_MOBILE": "Enlaces"aligns with the desktop"LABEL": "Enlace".
714-716: Mobile label for files looks good
"LABEL_MOBILE": "Archivos"is concise and accurate.
724-726: New recording source entry looks good
"LABEL": "Grabar"is clear and consistent with neighbouring keys.
728-728: Re-ordering only – no issues
"LABEL": "Búsqueda de Imágenes"unchanged except for position.
I've added some of the missing Spanish translations, including in the next scenarios: 'GENERAL', 'UPLOAD_SOURCE', 'RECORD_SOURCE'.
Summary by CodeRabbit
New Features
Bug Fixes
Style