-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement priority sorting logic for LearnEth tutorials #6504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| }, | ||
| effects: { | ||
| *loadRepo({ payload }, { put, select }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be rollbacked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s right. This was written temporarily to use mock data, so please just check the priority logic. I’ll roll it back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update has been completed.
0c026cb to
f717126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I've update the remix-workshops so that each .yml file has a priority key. So the dummy data can be removed here. |
f717126 to
e32b85f
Compare
@ryestew The description was originally read from the README file, but it has been changed to be fetched from the summary field in the .yml file. |
ryestew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me
830f5e4 to
cdb3738
Compare
cdb3738 to
04fa76e
Compare
|
View your CI Pipeline Execution ↗ for commit 04fa76e
☁️ Nx Cloud last updated this comment at |
|
❌ E2E failures detected (workflow: web) Last run: Mon, Dec 8, 2025, 06:09 AM UTC Top failing tests (1/1):
Report generated by CI; artifacts are retained per CircleCI retention settings. |



fixes #6501
This PR implements the new sorting logic for LearnEth tutorials as requested and sets the filter panel to be open by default.
Key Changes
Home/index.tsx):Level(asc)priority(asc, lower numbers first)name(alphabetical)priorityare sorted last, alphabetically by name.Home/index.tsx):showFilterstotrue.workshop.ts):.ymlfiles are not yet updated with thepriorityfield, I have added mock data inworkshop.tsto allow for immediate testing.loadRepofunction is commented out, and a temporaryloadRepois used to inject this mock data..ymlfiles are updated and deployed,workshop.tscan be easily reverted (uncomment original function, delete mock data).@ryestew Please review the new sorting logic and the default filter state.