fixed delayuntil in kauri's begin #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meling
requested changes
Nov 17, 2025
Member
meling
left a comment
meling
left a comment
There was a problem hiding this comment.
I wonder if it would be possible to get Copilot to prepare some test cases for the Kauri implementation. Perhaps guiding it to use the clique_test.go as a basis? Could you give it a go @hanish520?
protocol/comm/kauri.go
Outdated
| k.logger.Debug("Current view is higher than event view, not starting kauri") | ||
| return | ||
| } | ||
| k.begin(event.p, event.pc) |
Member
There was a problem hiding this comment.
Maybe something like this:
if err := k.begin(event.p, event.pc); err != nil {
k.logger.Errorf("Failed to begin kauri: %v", err)
}
Alternatively, if this is not a critical error to log but we still want to log it, we could use Debugf to only display it during debugging.
If we want to ignore the error, we should do:
_ = k.begin(event.p, event.pc)
protocol/comm/kauri.go
Outdated
| // begin starts dissemination of proposal and aggregation of votes. | ||
| func (k *Kauri) begin(p *hotstuff.ProposeMsg, pc hotstuff.PartialCert) error { | ||
| if !k.initDone { | ||
| // TODO(meling): This is not correct use of DelayUntil, see issue #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267