Skip to content

Add CVar: mp_max_alive_name_changes #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
In-line wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add CVar: mp_max_alive_name_changes #236

In-line wants to merge 4 commits into from

Conversation

@In-line
Copy link
Collaborator

@In-line In-line commented Dec 12, 2017 •
edited by wopox1337
Loading

Resolve #38

@WPMGPRoSToTeMa
Copy link
Contributor

WPMGPRoSToTeMa commented Dec 13, 2017

Will you add a cooldown cvar?

hajimura
hajimura reviewed Dec 13, 2017
View reviewed changes
@In-line
Copy link
Collaborator Author

In-line commented Dec 13, 2017

@WPMGPRoSToTeMa Do we really need a cooldown cvar? I guess solution with limiting nickname changes per spawn is more verbose (we have #Name_change_at_respawn which will be printed when limit is reached).

@In-line In-line changed the title [WIP] Nickname change limit (fix #38) Nickname change limit (fix #38) Dec 13, 2017
@s1lentq s1lentq force-pushed the master branch 3 times, most recently from 6342fc2 to 62cb200 Compare June 7, 2019 19:30
@s1lentq s1lentq force-pushed the master branch 2 times, most recently from 3dee6bb to 5bbba22 Compare April 2, 2020 11:28
@s1lentq s1lentq force-pushed the master branch 3 times, most recently from 6ae3127 to 5bbba22 Compare April 22, 2020 10:40
@GiovaniFerraroTrivelli
Copy link

GiovaniFerraroTrivelli commented May 16, 2020

BUMP. This is a great addition to stop some annoying cheaters.

@RauliTop
Copy link
Contributor

RauliTop commented Jun 17, 2021 •
edited
Loading

Please, what are you waiting to merge this?
Also add an option to the cvar to block name change inside server. For example: -2

@StevenKal
Copy link
Contributor

StevenKal commented Aug 24, 2021

I suggest to add the new member "m_iNickChangesBeforeSpawn" in the CCSPlayer's listing, after "m_bGameForcingRespawn", just to avoid breaking offsets after "m_flLastCommandTime" (m_iLastAccount, etc. + following CBot & CCSBot ones).

@wopox1337 wopox1337 self-assigned this Aug 31, 2021
@wopox1337 wopox1337 marked this pull request as draft August 31, 2021 21:15
@wopox1337 wopox1337 added Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: 🚧 in progress Task currently being worked on. Type: 🚀 enhancement Improvement or addition of a new feature. labels Aug 31, 2021
@wopox1337 wopox1337 changed the title Nickname change limit (fix #38) Nickname change limit Sep 1, 2021
@wopox1337 wopox1337 changed the title Nickname change limit Add CVar: mp_max_alive_name_changes Sep 1, 2021
@wopox1337 wopox1337 requested a review from s1lentq September 1, 2021 06:50
@s1lentq s1lentq force-pushed the master branch 4 times, most recently from a363cba to 79cfd71 Compare July 14, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1lentq s1lentq Awaiting requested review from s1lentq

1 more reviewer

@hajimura hajimura hajimura left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wopox1337 wopox1337

@In-line In-line

Labels

Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: 🚧 in progress Task currently being worked on. Type: 🚀 enhancement Improvement or addition of a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add name change cooldown and cvar for it

7 participants

@In-line @WPMGPRoSToTeMa @GiovaniFerraroTrivelli @RauliTop @StevenKal @hajimura @wopox1337