OPS-833: Add extra logos to finance page

[carlosabadia]

No description provided.

[linear]

OPS-833 Add extra logos to finance page

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds two new company logos (Ant Group and S&P Global) to the finance page and transitions from a static grid layout to an animated carousel display using the marquee component.

Key Changes

• New Assets: Added antgroup.svg and spglobal.svg logo files to assets/companies/light/
• Layout Transition: Converted the finance social proof section from a static 6-column grid to a horizontal scrolling carousel
• Carousel Configuration: Set pause_on_hover=False in the logos carousel to maintain continuous animation
• Code Restructuring: Introduced a local first_card function and LOGOS constant in the finance social proof module

Architecture Notes

The implementation follows the existing pattern established in the healthcare page, which also uses the logos carousel. The carousel only displays light mode logos (no dark mode variants), which is consistent with the healthcare implementation where none of the logos have dark mode versions either.

Code Quality Consideration

The first_card function is duplicated between finance and healthcare social proof modules. While this is a minor style issue, consolidating this function into a shared location would improve maintainability.

Confidence Score: 4/5

• This PR is safe to merge with low risk - it adds visual assets and updates UI layout without affecting business logic
• The changes are primarily cosmetic (adding logos and switching to a carousel layout) with minimal code complexity. The only notable issue is code duplication of the first_card function, which is a style concern rather than a functional problem. All changes follow established patterns in the codebase (healthcare page uses identical approach). No security, performance, or logical errors were found.
• The finance social_proof.py file could benefit from refactoring to eliminate the duplicated first_card function, but this is a minor style improvement rather than a critical issue

Important Files Changed

File Analysis

Filename	Score	Overview
assets/companies/light/antgroup.svg	5/5	New SVG logo file added for Ant Group - standard SVG asset with no issues
assets/companies/light/spglobal.svg	5/5	New SVG logo file added for S&P Global - standard SVG asset with no issues
pcweb/pages/use_cases/common/logos_carousel.py	5/5	Added pause_on_hover=False parameter to marquee component - straightforward config change
pcweb/pages/use_cases/finance/views/social_proof.py	3/5	Switched from grid layout to carousel, added new logos; contains duplicated first_card function that should be refactored

Sequence Diagram

sequenceDiagram
    participant User
    participant Browser
    participant FinancePage as Finance Page
    participant SocialProof as social_proof()
    participant LogosCarousel as logos_carousel()
    participant Marquee as Marquee Component
    participant Assets as SVG Assets

    User->>Browser: Visit Finance Page
    Browser->>FinancePage: Load page
    FinancePage->>SocialProof: Render social_proof()
    SocialProof->>SocialProof: Render first_card("Trusted by...")
    SocialProof->>LogosCarousel: Call logos_carousel(LOGOS)
    Note over LogosCarousel: LOGOS = ["man_group", "world_bank",<br/>"credit_agricole", "bayesline",<br/>"antgroup", "spglobal"]
    
    loop For each logo in LOGOS
        LogosCarousel->>LogosCarousel: Create social_proof_card(logo)
        LogosCarousel->>Assets: Request /companies/light/{logo}.svg
        Assets-->>LogosCarousel: Return SVG image
    end
    
    LogosCarousel->>Marquee: Create marquee with cards
    Note over Marquee: Config: direction="left",<br/>speed=50, pause_on_hover=False,<br/>gradient_width=0
    
    Marquee-->>SocialProof: Return carousel component
    SocialProof-->>FinancePage: Return social proof section
    FinancePage-->>Browser: Render page
    Browser-->>User: Display finance page with scrolling logos

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}