-
Notifications
You must be signed in to change notification settings - Fork 23
Switch to biome for frontend formatting #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I can see that it caught a lot in the linter... including our stomping on a Javascript global name Does biomejs fix the problems too? |
|
it does have an option to fix, though it's limited in what it's able to change, similarly to eslint. |
|
Alternatively, there's also oxlint which is made by the core Vue team themselves, but I haven't given it a try yet - maybe another avenue worth exploring. |
| "bumps/**/*", | ||
| "src/components/ModelViewPlotly.vue", | ||
| ], | ||
| "exclude": ["node_modules/", "bumps/**/*", "src/components/ModelPanelPlotly.vue"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, @bmaranville it's gone now
BiomeJS is a linter and formatter written in rust that provides:
After some exploration and discussion with @bmaranville we have decided to use biome for formatting,
and continue using eslint for linting until either biome or oxlint gets to a state where they fully support Vue files, including deeper inspection of the sections.