Skip to content

audit: veRef auditing comments #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
think-in-universe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audit: veRef auditing comments #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contracts/ref-ve/src/account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ pub struct Account {
#[serde(skip_serializing)]
pub proposals: HashMap<u32, VoteDetail>,
/// Record expired proposal voting info
/// [Audit] Suggestion: proposal history can be queried from TheGraph if proposal events are emitted,
/// so not necessary to save in contract state which introduces extra storage cost
#[serde(skip_serializing)]
pub proposals_history: UnorderedMap<u32, VoteDetail>,
#[serde(with = "u128_map_format")]
Expand Down Expand Up @@ -87,6 +89,7 @@ impl Account {
pub fn sub_reward(&mut self, token_id: &AccountId, amount: Balance) {
if let Some(prev) = self.rewards.remove(token_id) {
require!(amount <= prev, E101_INSUFFICIENT_BALANCE);
// [Audit] Suggestion: better use `remaining` as a variable name
let remain = prev - amount;
if remain > 0 {
self.rewards.insert(token_id.clone(), remain);
Expand Down
2 changes: 2 additions & 0 deletions contracts/ref-ve/src/storage_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ impl StorageManagement for Contract {

self.internal_remove_account(&account_id);
if account.sponsor_id != env::current_account_id(){
// [Audit] Risk: If one account locked LPT, and unlocked after a while, he/she can call `storage_unregister`
// to receive storage refund even if he/she didn't run `storage_deposit` before
Promise::new(account.sponsor_id).transfer(STORAGE_BALANCE_MIN_BOUND);
}
true
Expand Down