refactor: Remove redundant try/except around opentelemetry imports

Use module-level tracer instead of defensive inline imports

Author: abrookins

redis_sre_agent/agent/knowledge_agent.py

@@ -165,20 +165,12 @@ def _sanitize_messages_for_llm(msgs: list[BaseMessage]) -> list[BaseMessage]:
             try:
                 import time as _time
 
-                try:
-                    from opentelemetry import trace as _otel_trace  # type: ignore
-                except Exception:
-                    _otel_trace = None  # type: ignore
                 from redis_sre_agent.observability.llm_metrics import record_llm_call_metrics
 
                 _t0 = _time.perf_counter()
-                _tr = _otel_trace.get_tracer(__name__) if _otel_trace else None
-                if _tr:
-                    with _tr.start_as_current_span(
-                        "llm.call", attributes={"llm.component": "knowledge"}
-                    ):
-                        response = await llm_with_tools.ainvoke(messages)
-                else:
+                with tracer.start_as_current_span(
+                    "llm.call", attributes={"llm.component": "knowledge"}
+                ):
                     response = await llm_with_tools.ainvoke(messages)
                 record_llm_call_metrics(
                     component="knowledge", llm=llm_with_tools, response=response, start_time=_t0

redis_sre_agent/agent/runbook_generator.py

@@ -235,18 +235,10 @@ async def _generate_research_summary(
 
         import time as _time
 
-        try:
-            from opentelemetry import trace as _otel_trace  # type: ignore
-        except Exception:
-            _otel_trace = None  # type: ignore
         from redis_sre_agent.observability.llm_metrics import record_llm_call_metrics
 
         _t0 = _time.perf_counter()
-        _tr = _otel_trace.get_tracer(__name__) if _otel_trace else None
-        if _tr:
-            with _tr.start_as_current_span("llm.call", attributes={"llm.component": "runbook"}):
-                response = await self.llm.ainvoke([HumanMessage(content=prompt)])
-        else:
+        with tracer.start_as_current_span("llm.call", attributes={"llm.component": "runbook"}):
             response = await self.llm.ainvoke([HumanMessage(content=prompt)])
         record_llm_call_metrics(
             component="runbook", llm=self.llm, response=response, start_time=_t0
@@ -480,20 +472,10 @@ async def _evaluate_runbook(self, runbook: GeneratedRunbook) -> RunbookEvaluatio
 
         import time as _time
 
-        try:
-            from opentelemetry import trace as _otel_trace  # type: ignore
-        except Exception:
-            _otel_trace = None  # type: ignore
         from redis_sre_agent.observability.llm_metrics import record_llm_call_metrics
 
         _t0 = _time.perf_counter()
-        _tr = _otel_trace.get_tracer(__name__) if _otel_trace else None
-        if _tr:
-            with _tr.start_as_current_span("llm.call", attributes={"llm.component": "runbook"}):
-                response = await self.llm.ainvoke(
-                    [SystemMessage(content=system_prompt), HumanMessage(content=user_prompt)]
-                )
-        else:
+        with tracer.start_as_current_span("llm.call", attributes={"llm.component": "runbook"}):
             response = await self.llm.ainvoke(
                 [SystemMessage(content=system_prompt), HumanMessage(content=user_prompt)]
             )