fix: Resolve runtime errors in agent execution

- Rename Tool.schema to Tool.definition to avoid shadowing BaseModel attribute
- Use getattr for llm.model and llm.temperature to handle ChatOpenAI which uses model_name

Author: abrookins

redis_sre_agent/agent/langgraph_agent.py

@@ -369,8 +369,9 @@ def _messages_cache_key(self, messages: List[BaseMessage]) -> str:
     async def _ainvoke_memo(self, tag: str, llm: Any, messages: List[BaseMessage]):
         if not self._run_cache_active:
             return await llm.ainvoke(messages)
-        model = llm.model
-        temperature = llm.temperature
+        # LLM objects use different attribute names: model, model_name, or _model
+        model = getattr(llm, "model", None) or getattr(llm, "model_name", None) or "unknown"
+        temperature = getattr(llm, "temperature", 0.0)
         key = f"{tag}|{model}|{temperature}|{self._messages_cache_key(messages)}"
         if key in self._llm_cache:
             return self._llm_cache[key]

redis_sre_agent/tools/manager.py

@@ -268,7 +268,7 @@ def get_tools(self) -> List[ToolDefinition]:
         Returns:
             List of ToolDefinition objects for LLM binding
         """
-        return [t.schema for t in self._tools]
+        return [t.definition for t in self._tools]
 
     def get_tools_by_provider_names(self, provider_names: List[str]) -> List[ToolDefinition]:
         """Return tools belonging to providers with given provider_name values.
@@ -289,7 +289,7 @@ def get_tools_by_provider_names(self, provider_names: List[str]) -> List[ToolDef
                 provider = self._routing_table.get(tool.metadata.name)
                 pname = provider.provider_name if provider else None
                 if isinstance(pname, str) and pname.lower() in wanted:
-                    results.append(tool.schema)
+                    results.append(tool.definition)
             return results
         except Exception:
             # Be conservative; if anything goes wrong, return no tools
@@ -362,7 +362,7 @@ def _filter_tools_by_providers(self, providers: List["ToolProvider"]) -> List[To
                 p = self._routing_table.get(tool.metadata.name)
                 if not p or id(p) not in provider_ids:
                     continue
-                results.append(tool.schema)
+                results.append(tool.definition)
             return results
         except Exception:
             return []

redis_sre_agent/tools/models.py

@@ -32,19 +32,19 @@ class ToolMetadata(BaseModel):
 
 
 class Tool(BaseModel):
-    """Concrete tool object combining schema, metadata, and executor.
+    """Concrete tool object combining definition, metadata, and executor.
 
     Attributes:
         metadata: :class:`ToolMetadata` describing the tool for routing.
-        schema: The :class:`ToolDefinition` shown to the LLM.
+        definition: The :class:`ToolDefinition` shown to the LLM.
         invoke: Async callable taking a single ``Dict[str, Any]`` of arguments
             and returning the tool result.
     """
 
     model_config = ConfigDict(arbitrary_types_allowed=True)
 
     metadata: ToolMetadata
-    schema: "ToolDefinition"
+    definition: "ToolDefinition"
     invoke: Callable[[Dict[str, Any]], Awaitable[Any]]
 
 

redis_sre_agent/tools/protocols.py

@@ -385,7 +385,7 @@ def tools(self) -> List["Tool"]:
             async def _invoke(args: Dict[str, Any], _method=method) -> Any:
                 return await _method(**(args or {}))
 
-            tools.append(Tool(metadata=meta, schema=schema, invoke=_invoke))
+            tools.append(Tool(metadata=meta, definition=schema, invoke=_invoke))
         return tools
 
     def get_status_update(self, tool_name: str, args: Dict[str, Any]) -> Optional[str]: