Skip to content

improvement: fallback to guessing error type from HTTP status code in HEAD requests #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SinusPi wants to merge 5 commits into
base: v3-v2021-02-25
Choose a base branch
from
Open

improvement: fallback to guessing error type from HTTP status code in HEAD requests #673

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
774dc86
feat: allow for http adapter param
saas786 Sep 28, 2021
e20809e
Merge remote-tracking branch 'github-saas/syed/v3-v2021-02-25/guzzle'…
Mar 4, 2022
1071e2f
Revert "Merge remote-tracking branch 'github-saas/syed/v3-v2021-02-25…
Mar 4, 2022
11d8872
Fallback to guessing error type from HTTP status code even if "Conten…
Mar 14, 2022
337cc77
Merge branch 'recurly:v3-v2021-02-25' into issue--support-errors-in-head
SinusPi Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/recurly/recurly_error.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,17 @@ public static function fromResponse(\Recurly\Response $response): \Recurly\Recur
$api_error = \Recurly\Resources\ErrorMayHaveTransaction::fromResponse($response, $error);
return new $klass($error->message, $api_error);
}
} else {
$error_type = static::errorFromStatus($response->getStatusCode());
$klass = static::titleize($error_type, '\\Recurly\\Errors\\');
if (class_exists($klass)) {
return new $klass('An unexpected error has occurred');
}
}

// "Content-type: application/json" may appear without a body after a HEAD request.
// If the above failed, try guessing from the status code.
$error_type = static::errorFromStatus($response->getStatusCode());
$klass = static::titleize($error_type, '\\Recurly\\Errors\\');
if (class_exists($klass)) {
return new $klass('An unexpected error has occurred');
}

// No valid error type was found, sorry.
$klass = static::_defaultErrorType($response);
return new $klass('An unexpected error has occurred');

Expand Down