Fix: Retry builds were not being cancelled properly (#12615) #12640
+119
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where a build created as
retrywould not changeto
cancelledwhen a cancel action was triggered on the original build.Details
Retry builds inherit the previous build state, but were not part of the
state transition that sets a build to
cancelled. This caused retrybuilds to remain active even after cancellation.
This PR updates the cancel logic so that:
cancelledTesting
A regression test is added:
Covers:
Issue reference
Fixes #12615