Harmonizes use of resetUo() in genConstruction() with pyOSut #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgix
commented
Jan 3, 2026
|
|
||
| unless mt.setThermalResistance(r) | ||
| return invalid("Failed #{id}: RSi#{de_r.round(2)}", mth) | ||
| return invalid("Failed #{id}: RSi#{r.round(2)}", mth) |
brgix
commented
Jan 3, 2026
| else | ||
| c.setLayer(index, lyr.get) | ||
| end | ||
| resetUo(c, film, index, u) |
brgix
commented
Jan 3, 2026
| expect(u).to be_within(TOL).of(uo2) | ||
| expect(surface.layers[0].nameString).to eq("OSut:concrete:200") | ||
| expect(surface.layers[1].nameString).to eq("OSut:polyiso:K0.023:100") | ||
| expect(surface.layers[1].nameString).to eq("OSut:K0.023:100") |
Member
Author
There was a problem hiding this comment.
Method resetUo adjusts a construction's insulating layer properties, e.g.
- thermal conductivity
- thickness
... the (adjusted) insulating material is renamed accordingly.
This was
linked to
issues
Jan 3, 2026
This was referenced Jan 3, 2026
brgix
referenced
this pull request
in NREL/openstudio-standards
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonizes use of resetUo in genConstruction with pyOSut approach.