Multy column sorting #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ravid7000/table-sortable/4m7HZBQtAAJaKFgwLTk27xBVsAbz |
ravid7000
reviewed
Sep 21, 2021
Owner
ravid7000
left a comment
ravid7000
left a comment
There was a problem hiding this comment.
I'm not sure this multi-column sorting is a good thing. Sorting can be done on one column at a time. I'm working on improving the sorting and introduce 3 ways sorting and that will work on single column at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow table sorting by number of columns simultatiously.
Also fixed my issue with empty cell value #23 (commented in src/DataSet/index.js)