-
Notifications
You must be signed in to change notification settings - Fork 75
Use SPDX license identifiers in pyproject.toml, remove setup.py, bump build dependency floors
#752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
setup.py, bump build dependency floors
|
/ok to test |
|
The |
setup.py, bump build dependency floorssetup.py, bump build dependency floors
| "notebooks.*", | ||
| "tests", | ||
| "tests.*", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is working. The count of files and total size is matching what I see on main.
checking '/tmp/wheelhouse/cuxfilter_cu12-26.2.0a14-py3-none-manylinux_2_28_aarch64.manylinux_2_28_x86_64.whl'
----- package inspection summary -----
file size
* compressed size: 89.006K
* uncompressed size: 0.283M
* compression space saving: 69.3%
contents
* directories: 0
* files: 66 (0 compiled)
size by extension
* .py - 0.253M (89.4%)
* no-extension - 30.564K (10.6%)
* .txt - 10.0B (0.0%)
largest files
* (19.426K) cuxfilter/charts/datashader/custom_extensions/holoviews_datashader.py
* (19.172K) cuxfilter/dashboard.py
* (18.585K) cuxfilter/charts/panel_widgets/plots.py
* (17.256K) cuxfilter/charts/datashader/datashader.py
* (14.774K) cuxfilter/charts/core/non_aggregate/core_graph.py
------------ check results -----------
errors found while checking: 0
Checked by building locally as well.
pushd ./python
pip wheel --no-deps -v .
unzip -l ./cuxfilter*.whl|
/merge |
98a3dae to
9a6aa18
Compare
Contributes to rapidsai/build-planning#152
Proposes the following changes, to prevent builds breaking when Python build backends
start to require configuration consistent with PEP 639 (link):
[project].license[tool.setuptools].license-filesto[project].license-filesLicense ::trove classifierssetuptools>=77.0.0and / orscikit-build-core>=0.11.0)As part of this, also moves all remaining configuration out of
setup.pyand intopyproject.tomlso this project won't be broken ifsetuptoolseventually removes PEP 517 (link) support.setup.pypyproject.tomlCONTRIBUTING.mdto stop recommendingpython setup.py install