Skip to content

Update the test matrix for GitHub #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jheysel-r7 merged 2 commits into from
May 6, 2025
Merged

Update the test matrix for GitHub #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbea460
Update the test matrix for GitHub
zeroSteiner May 6, 2025
721137b
Fix a #pack format string for Ruby 3.3
zeroSteiner May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ jobs:
- '3.0'
- '3.1'
- '3.2'
- '3.3'
- '3.4'
os:
- ubuntu-20.04
- ubuntu-22.04
- ubuntu-latest
exclude:
- { os: ubuntu-latest, ruby: '2.7' }
Expand Down
6 changes: 3 additions & 3 deletions spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
RSpec.describe RubySMB::Dcerpc::Samr::UserProperties do
describe '#read' do
context 'when reading a structure with no user properties' do
let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96<SC') }
let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96SC') }
let(:subject) { described_class.read(binary) }

it 'does not include the property_count' do
Expand All @@ -23,7 +23,7 @@
let(:user_property1) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key1', property_value: 'value1') }
let(:user_property2) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key2', property_value: 'value2') }
let(:user_properties) { user_property1.to_binary_s + user_property2.to_binary_s }
let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96<S<S') + user_properties + "\x00".b }
let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96S<S') + user_properties + "\x00".b }
let(:subject) { described_class.read(binary) }

it 'includes the property_count' do
Expand Down Expand Up @@ -73,4 +73,4 @@
expect(subject.user_properties).to be_empty
end
end
end
end
Loading