Add structured logging of all previously-swallowed errors #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change pulls in the log facade with its key-value feature, and then uses `inspect_err` before each call to `map_err` (and `is_ok`) to get the errors surfaced, should a user want to see them. I chose `warn!` for most of the errors, and `debug!` primarily for construction/generation tasks, where failures may be less surprising. I'm not committed to any of the levels, and happy to remove any that you think aren't useful.
Owner
|
Thanks! This will need to be rebased on #44 and the CI is also not happy. Otherwise it looks good. EDIT: The fix for the CI is here: jedisct1/rust-blind-rsa-signatures#11 |
Author
|
I left all the logging as-is on first review, but given the changes from #44 I could see cutting out many of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change pulls in the log facade with its key-value feature,
and then uses
inspect_errbefore each call tomap_err(andis_ok) to get the errors surfaced, should a user want to seethem.
I chose
warn!for most of the errors, anddebug!primarilyfor construction/generation tasks, where failures may be less
surprising. I'm not committed to any of the levels, and happy
to remove any that you think aren't useful.