Removing pending_jobs column

* Without always updating it on the fly, it's always the same as total_jobs, or is 0. So it's not really useful as a distinct column

Author: jpcamara

app/models/solid_queue/batch.rb

@@ -68,7 +68,6 @@ def check_completion!
           finished_attributes[:failed_jobs] = failed
         end
         finished_attributes[:completed_jobs] = total_jobs - failed
-        finished_attributes[:pending_jobs] = 0
 
         update!(finished_attributes)
         execute_callbacks

app/models/solid_queue/batch/trackable.rb

@@ -57,7 +57,7 @@ def failed_jobs
       end
 
       def pending_jobs
-        finished? ? self[:pending_jobs] : batch_executions.count
+        finished? ? 0 : batch_executions.count
       end
 
       def progress_percentage

app/models/solid_queue/batch_execution.rb

@@ -25,7 +25,7 @@ def create_all_from_jobs(jobs)
 
           total = jobs.size
           SolidQueue::Batch.upsert(
-            { batch_id:, total_jobs: total, pending_jobs: total },
+            { batch_id:, total_jobs: total },
             **provider_upsert_options
           )
         end
@@ -39,14 +39,13 @@ def provider_upsert_options
             {
               unique_by: :batch_id,
               on_duplicate: Arel.sql(
-                "total_jobs = solid_queue_batches.total_jobs + excluded.total_jobs, " \
-                "pending_jobs = solid_queue_batches.pending_jobs + excluded.pending_jobs"
+                "total_jobs = solid_queue_batches.total_jobs + excluded.total_jobs"
               )
             }
           else
             {
               on_duplicate: Arel.sql(
-                "total_jobs = total_jobs + VALUES(total_jobs), pending_jobs = pending_jobs + VALUES(pending_jobs)"
+                "total_jobs = total_jobs + VALUES(total_jobs)"
               )
             }
           end

lib/generators/solid_queue/install/templates/db/queue_schema.rb

@@ -129,7 +129,6 @@
     t.text "on_failure"
     t.text "metadata"
     t.integer "total_jobs", default: 0, null: false
-    t.integer "pending_jobs", default: 0, null: false
     t.integer "completed_jobs", default: 0, null: false
     t.integer "failed_jobs", default: 0, null: false
     t.datetime "enqueued_at"

test/dummy/db/queue_schema.rb

@@ -141,7 +141,6 @@
     t.text "on_failure"
     t.text "metadata"
     t.integer "total_jobs", default: 0, null: false
-    t.integer "pending_jobs", default: 0, null: false
     t.integer "completed_jobs", default: 0, null: false
     t.integer "failed_jobs", default: 0, null: false
     t.datetime "enqueued_at"