We no longer need to keep jobs

* Batch execution is managed through the BatchExecution model, which is dependent destroyed when jobs are destroyed

* Since it checks batch completion in an after_commit on: :destroy, it already gets checked, even when the job is not preserved

* Because we rely on batch executions and counts, we don't need the jobs to stick around to properly run a batch

Author: jpcamara

app/jobs/solid_queue/batch/cleanup_job.rb

@@ -111,12 +111,6 @@ def execute_callbacks
         end
 
         perform_completion_job(:on_finish, {}) if on_finish.present?
-
-        clear_unpreserved_jobs
-      end
-
-      def clear_unpreserved_jobs
-        SolidQueue::Batch::CleanupJob.set(queue: self.class.maintenance_queue_name || "default").perform_later(self) unless SolidQueue.preserve_finished_jobs?
       end
 
       def enqueue_empty_job

app/models/solid_queue/batch.rb

@@ -78,7 +78,7 @@ def dispatch_bypassing_concurrency_limits
       end
 
       def finished!
-        if SolidQueue.preserve_finished_jobs? || batch_id.present? # We clear jobs after the batch finishes
+        if SolidQueue.preserve_finished_jobs?
           update!(finished_at: Time.current)
         else
           destroy!