NOMERGE PR.js Build Improvements #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmercer
force-pushed
the
gulp-novicepiece
branch
2 times, most recently
from
27efd44 to
84d9ce4
Compare
* Adds build script to package.json * Formatting cleanup, courtesy of jspm * Adds build.min.js files to gitignore * Installs require-dir * Refactors gulp setup * Activates live reload in gulp serve * Adds dist/ to gitignore * Adds buildjs task * Adds Travis-CI integration * adds clean task * Extracts buildjs task into its own file * Adds build image task * Adds css build task
* The default task now runs both build and test * Travis now runs `gulp` instead of `gulp build` * Adds 'test' to package.json scripts * Restores jspm's config.js * Per jspm docs, adds jspm as npm devDependency * Travis now runs npm & jspm locally, not globally * TODO: setup PhantomJS testing * Currently, the parsers and validators are tested * BUT the UI code is NOT tested * We must add UI code testing at some point.
* Also, removes cached files which shouldn't be in the index.
jfmercer
force-pushed
the
gulp-novicepiece
branch
from
84d9ce4 to
03bc39a
Compare
Author
|
@nateabele @gavD @ovaska Feedback appreciated. |
Author
There was a problem hiding this comment.
Yes. Those files current go into root. I'd prefer them to be in build/ and dist/, but I haven't found a way to do so without breaking everything. Wherever they go, they should not be committed to the repo, but rather be generated in the by gulp build. For the time being, they're stuck in root until I find a better solution.
* This implements [these instructions](https://github.com/jspm/jspm-cli/wiki/Registries#travis-ci). * Security Note: It is safe to commit the encrypted string to version control. Only Travis can unlock it.
jfmercer
force-pushed
the
gulp-novicepiece
branch
from
732ab58 to
593485e
Compare
jfmercer
force-pushed
the
gulp-novicepiece
branch
from
850af9b to
b05c3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOMERGE PR.js Build Improvements
Please note
Overall Goal
build/dir for development & adist/dir where everything works "out of the box"Completed
gulp servenow has live reloadimg/go todist/buildjstask is incompletebuild.min.jsandbuild.min.js.maps. If there is other JS that needs minification, it hasn't been done yet.parsers/andvalidators/are tested, but notUI/Incomplete
UI/tests with PhantomJSwatchisn't set upConclusion