Added Scalastyle support to the entire project in a way to be informative, but not fail the build. #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdschei
force-pushed
the
REP-4923_AddScalastyleSupport
branch
from
a5e7182 to
3036a12
Compare
…tive, but not fail the build.
wdschei
force-pushed
the
REP-4923_AddScalastyleSupport
branch
from
3036a12 to
092f4fb
Compare
Contributor
|
Looks like building a style checker directly into the scala compiler is on the roadmap. https://www.scala-lang.org/news/2.12-roadmap Although, I'm not sure that it landed on 2.12.0. Wondering if we should be leveraging that when it comes out.... ... or I guess we'd have the same style rules either way. |
Contributor
Author
|
Interesting. I wonder if it will use the same Scalastyle files to configure it. |
Contributor
|
Maybe, but I'm not holding by breath. If it's built into the compiler, it will probably have much more detailed checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.