add support for functions #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- evaluate and validate function arguments - create a standard pattern for defining functions - add a "functions standard library" initially with just a `starts_with` function for strings.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for functions within the rule parser and evaluator and introduces the functions standard library with an initial implementation of the starts_with function. Key changes include:
- Updates to the parser (grammar and tokenization) to distinguish function calls from field identifiers.
- New tests and standard library files supporting function evaluation.
- Adjustments to lexer and parser generation to recognize function syntax.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rule_test.go | Adds tests for function parsing and evaluation. |
| rule.go | Updates rule string formatting and introduces RuleFunc helper. |
| parser.y, parser.go | Extends grammar and token handling to support function calls. |
| parser.gen.go | Regenerates parser constants for function-related tokens. |
| lexer.rl, lexer.go | Modifies lexer rules to tokenize function names using token_FUNCTION. |
| functions_stdlib*.go | Introduces functions standard library and tests, including starts_with. |
| functions.go | Implements FunctionValue with evaluation, validation, and argument mapping. |
| errors.go | Adds error type for invalid function arguments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function_name(argument1, argument2)starts_withfunction.