Update UnbindFiltersFromProjections helper function
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I am able to build Cockroach after applying these changes to |
vijaysharma4
changed the title
UnbindFiltersFromProjections\ helper functionUnbindFiltersFromProjections helper function
WKaiZ
requested changes
Nov 28, 2025
Collaborator
WKaiZ
left a comment
WKaiZ
left a comment
There was a problem hiding this comment.
Did you make sure to run all the test cases with that change? Some changes are done to the original helper function to not run into the infinite loop issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
UnbindFiltersFromProjectionshelper function has already been defined in project_functions.go. However it hasn't been used in any of the generated rules and isn't used in the generator either, so maybe it was an intentional redefinition? (Currently the build errors for me because of it.)