Skip to content

Jb col7298 trend summary slide image fix #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justinboynton wants to merge 266 commits into
base: master
Choose a base branch
from
Open

Jb col7298 trend summary slide image fix #29

justinboynton wants to merge 266 commits into from

Conversation

@justinboynton
Copy link

@justinboynton justinboynton commented Jan 24, 2025

  • fix font size in trend-summary template
  • fix image size in trend-summary template
  • fix extra spaces being added to p > text from HTML conversion

Justin Boynton added 30 commits July 18, 2016 12:19
Update trend intro to ignore if no image
a543c40
update test to check with some later content
40966c5
remove unused require
09ccaaa
use more complex html in test
2e476ec
NVIS-1304 Embed other pptx files in the main file
82f6625 
 - Start the process of opening and embedding associated pptx files
WIP
701a4fb
Updates to use multipe masters and themes
01fa09c 
 - Now uses two masters and themes to support older embed content
 - Uses latest styling for web content
 - WIP unique nameing on embeded media and relations referencing for
   these
Embdeded charts
61e4d3f 
  - Charts now embedding correctly with rel files updated to have media
    and chart folders per slide
remove debug
8cce8eb
bump version
a896c12
NVIS-1304 PPTX generation from page builder
cbf58a8 
 - update to include notes correctly
 - reference media files correctly
NVIS-1304 Ensure pptx validates with OOXML tool
277239e 
 - Add in missing xsls file definition
 - Tidy up output
NVIS-1304 Updating template files
9b7da38
NVIS-1304 update heading template
f20662b
rename ruby presentation to stop clashes
3d6944f
refactor to include read powerpoint
e629cf6
update variable reference
f728a90
parse correct xml for embeds
f5d2620
NVIS-1304 only save extras if they exist
beb3d44
change write mode
1746a55
close file handles
188900a
remove close file handles
b3603f8
close open file handle
68355ec
NVIS-1304 close xml files
3748fba
close more open file handles
d5eeaf1
WIP refactor and tidy
d945930
WIP refactor
1cff402
Refactor
ef00681
refactor to work dynamically with embeded slide masters
6e6a596
bump version
2fc3821
EuanEdgar and others added 30 commits December 17, 2024 15:46
@EuanEdgar
Fix error from removing notes
0d07389
@EuanEdgar
Add missing slide templates
2d08d53
@EuanEdgar
Fix rogue textbox on trend list slide
47f0772
@EuanEdgar
Copy older slide master rel template
de7a1c3 
Fix embeds being assigned incorrect Id
@EuanEdgar
Handle blank test input for text with image slide
24da129
@EuanEdgar
Handle missing content in heading text slide
e04a7eb
@EuanEdgar
Handle more missing strings
4a36612
@EuanEdgar
Clean up files from template, rmeove some duplicate slide numbers
005d03e
@justinboynton
update fonts to fix repair issue
bd16320
@EuanEdgar
Remove cropping from intro slide image
ac36bca
@EuanEdgar
Replace numbered rId with text to avoid conflicts
7a4ade6
@EuanEdgar
Merge pull request #17 from stylefoundry/ee_collision_2025
7e15b74 
2025 template
@EuanEdgar
COLL-7290: Remove duplicate slide number on heading_text slide
edbc802
@EuanEdgar
COLL-7291: 2 column chart image sizing
1678783
@EuanEdgar
COLL-7292: 3 column component title should be full-width
270687f
@EuanEdgar
COLL-7288: Change what will happen next font size
6ba46ad
@EuanEdgar
7289: Change background colour of screenshot component slides
5e838a9
@EuanEdgar
COLL-7286: Remove white line from logo on intro slide
bcf1770
@EuanEdgar
COLL-7286: Replace gradient on intro slide
38eee17
@EuanEdgar
COLL-7286: Reduce intro slide title font size
e70b5bb
@EuanEdgar
COLL-7286: Disable autofit on intro slide subtitle
906598e 
This needs testing in powerpoint as I do not believe keynote respects this property
@EuanEdgar
COLL-7286: Increase size of subtitle text box on intro slide
8a05982
@EuanEdgar
COLL-7291: Fix image reference
2f3e0e9
@justinboynton
COL7297 image not text slide
2065605
@justinboynton
COL-7298 Trend Summary Slide
b5a5add 
 - create new slide for trend summary
 - update utlils to remove newlines from outputed oomxml
@justinboynton
update tests for trend_summary
e249e09
@justinboynton
Update util.rb
d2e7ae3 
 - remove unneed p spacing code
@justinboynton
Merge pull request #18 from stylefoundry/ee_jan_sprint
0be4c3b 
January sprint
@justinboynton
Fix image and font in strend summary slide
8aed402
@justinboynton
fixing COL 7294 spaces at start of p texdt
928b160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinboynton @EuanEdgar