gh-142236: Improve error location for missing comma in string concatenations #142330
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
gh-142236-2
branch
from
e5084f2 to
1c45d6c
Compare
…oncatenations When a multi-line string concatenation is missing a comma before the next argument, the error previously pointed to the first string in the concatenation, which was confusing because the actual fix needed to be applied after the last string. This change adds a helper function that detects multi-line expressions and adjusts the error position to point to the last line, making it immediately clear where the comma should be added.
pablogsal
force-pushed
the
gh-142236-2
branch
from
1c45d6c to
fbb59b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a multi-line string concatenation is missing a comma before the
next argument, the error previously pointed to the first string in the
concatenation, which was confusing because the actual fix needed to be
applied after the last string. This change adds a helper function that
detects multi-line expressions and adjusts the error position to point
to the last line, making it immediately clear where the comma should be
added.