Correct broken example for 'named_model' usage #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Arguments for `named_model` args are in the wrong order, which was a simple fix when checking the type annotations. - An exception is raised for a name collision: `AssertionError: Naming collision for <JSONPayload for <class 'pytest_factoryboy.fixture.JSONPayload'>>` - The test asserted an object property in stead of a dict value.
Contributor
|
thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage ? 97.85%
=========================================
Files ? 16
Lines ? 886
Branches ? 54
=========================================
Hits ? 867
Misses ? 8
Partials ? 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from #91: The referenced
named_modelusage example doesn't work, it has several issues.named_modelargs are in the wrong order, which was a simple fix when checking the type annotations.AssertionError: Naming collision for <JSONPayload for <class 'pytest_factoryboy.fixture.JSONPayload'>>