ci: add zizmor and tighten up CI #1035
Merged
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/ci/zizmor
branch
2 times, most recently
from
9593489 to
adc5c26
Compare
henryiii
commented
Jan 7, 2026
| url: https://pypi.org/project/packaging/${{ github.ref_name }} | ||
| permissions: | ||
| id-token: write | ||
| if: '!github.event.repository.fork' |
Contributor
Author
There was a problem hiding this comment.
This was not from zizmor, it just keeps forks that trigger this from trying to upload to PyPI.
| - name: Check ref is the commit SHA | ||
| # require SHA as tags and branches are mutable | ||
| run: test "${{ inputs.ref }}" | ||
| run: test "${INPUTS_REF}" |
Contributor
Author
There was a problem hiding this comment.
This protects against code expansion.
henryiii
force-pushed
the
henryiii/ci/zizmor
branch
from
adc5c26 to
9434e5e
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/ci/zizmor
branch
from
9434e5e to
5b1d7a9
Compare
brettcannon
approved these changes
Jan 8, 2026
Contributor
Author
|
@brettcannon Okay for me to try to tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #893, adding zizmor and addressing issues it found.