-
-
Notifications
You must be signed in to change notification settings - Fork 728
add tensors and basic operators #5335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5335 +/- ##
===========================================
- Coverage 98.64% 98.59% -0.05%
===========================================
Files 323 324 +1
Lines 28063 28211 +148
===========================================
+ Hits 27682 27816 +134
- Misses 381 395 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| >>> v2 = pybamm.VectorField(c, d) # rank-1 | ||
| >>> T = pybamm.tensor_product(v1, v2) # rank-2 tensor | ||
| """ | ||
| return TensorProduct(left, right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would left and right ever be constant (i.e. use simplify_if_constant) ?
Description
Adds tensors and some basic operators. Useful for some models which need these types of things.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests