Skip to content

Conversation

@pipliggins
Copy link
Contributor

@pipliggins pipliggins commented Dec 12, 2025

Re-implementation of #5191 for clearer implementation history

Allows input parameters used as initial conditions to be included within lists of inputs to the solver by converting model.y0 to model.y0_list, and calculating one initial state per input parameter set.

This rolls back a lot of the changes made by #4981 as the functionality is added to all the solvers; the initial_conditions argument added for IDAKLU has been removed in favour of allowing all inputs to be included within inputs.

Fixes #5154
Fixes #5131

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 99.03846% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.79%. Comparing base (a0b2614) to head (8d2cb3c).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/solvers/base_solver.py 98.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5311      +/-   ##
===========================================
+ Coverage    98.76%   98.79%   +0.02%     
===========================================
  Files          323      323              
  Lines        27744    27729      -15     
===========================================
- Hits         27402    27394       -8     
+ Misses         342      335       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pipliggins pipliggins marked this pull request as ready for review December 12, 2025 15:51
@pipliggins pipliggins requested a review from a team as a code owner December 12, 2025 15:51
martinjrobins
martinjrobins previously approved these changes Dec 16, 2025
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, thanks @pipliggins, all good to merge from me, although there was a failing test runner?

@pipliggins
Copy link
Contributor Author

this looks great, thanks @pipliggins, all good to merge from me, although there was a failing test runner?

I think that was just the link checker, but I've merged develop and will check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: input parameters that affect the initial condition not handled IDAKLU solver JAX: add option for multiple initial conditions

2 participants