-
-
Notifications
You must be signed in to change notification settings - Fork 728
Lists of input parameters in initial conditions #5311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Add IDAKLU integration test
…inuities into a single loop.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5311 +/- ##
===========================================
+ Coverage 98.76% 98.79% +0.02%
===========================================
Files 323 323
Lines 27744 27729 -15
===========================================
- Hits 27402 27394 -8
+ Misses 342 335 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martinjrobins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thanks @pipliggins, all good to merge from me, although there was a failing test runner?
I think that was just the link checker, but I've merged develop and will check again. |
Re-implementation of #5191 for clearer implementation history
Allows input parameters used as initial conditions to be included within lists of inputs to the solver by converting model.y0 to model.y0_list, and calculating one initial state per input parameter set.
This rolls back a lot of the changes made by #4981 as the functionality is added to all the solvers; the
initial_conditionsargument added for IDAKLU has been removed in favour of allowing all inputs to be included withininputs.Fixes #5154
Fixes #5131