Add informative error message to simulation #5226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5226 +/- ##
========================================
Coverage 98.77% 98.77%
========================================
Files 321 321
Lines 27729 27731 +2
========================================
+ Hits 27389 27391 +2
Misses 340 340 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… (pybamm-team#5253) Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
) * Fix typo in concentration description in notebook * Add CHANGELOG.md entry for typo fix * Remove unneccesary changelog entry Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> --------- Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
main -> develop
martinjrobins
previously approved these changes
Nov 20, 2025
Contributor
martinjrobins
left a comment
martinjrobins
left a comment
There was a problem hiding this comment.
this looks great, does #5191 change this at all?
* fix `InputParameter` serialisation * Update CHANGELOG.md
…rialisation-fix Don't be too strict with func_args longer than symbol.children
…-team#5285) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Contributor
Author
@martinjrobins No, #5191 doesn't touch any of the experiment/cycle solution code. |
BradyPlanden
dismissed
martinjrobins’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error message informing users that lists of input sets cannot be used with experiments.
Fixes #5200
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests