Skip to content

Commit 51f7a73

Browse files
jordanbreen28jordanbreen28
authored andcommitted
(CONT-971) - Correct Style/RedundantAssignment
1 parent 69cec29 commit 51f7a73

File tree

4 files changed

+3
-17
lines changed

4 files changed

+3
-17
lines changed

.rubocop_todo.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,6 @@ Style/OptionalBooleanParameter:
216216
- 'spec/spec_helper_acceptance_local.rb'
217217
- 'tests/beaker/lib/lvm_helper.rb'
218218

219-
# Offense count: 3
220-
# This cop supports safe autocorrection (--autocorrect).
221-
Style/RedundantAssignment:
222-
Exclude:
223-
- 'lib/puppet/provider/logical_volume/lvm.rb'
224-
- 'lib/puppet/provider/physical_volume/lvm.rb'
225-
- 'lib/puppet/provider/volume_group/lvm.rb'
226-
227219
# Offense count: 12
228220
# This cop supports safe autocorrection (--autocorrect).
229221
Style/RedundantRegexpEscape:

lib/puppet/provider/logical_volume/lvm.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ def self.get_logical_volumes
3737
full_lvs_output = lvs.split("\n")
3838

3939
# Remove first line
40-
logical_volumes = full_lvs_output.drop(1)
41-
42-
logical_volumes
40+
full_lvs_output.drop(1)
4341
end
4442

4543
def self.get_logical_volume_properties(logical_volumes_line)

lib/puppet/provider/physical_volume/lvm.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@ def self.get_physical_volumes
5353
full_pvs_output = pvs.split("\n")
5454

5555
# Remove first line
56-
physical_volumes = full_pvs_output.drop(1)
57-
58-
physical_volumes
56+
full_pvs_output.drop(1)
5957
end
6058

6159
def self.get_physical_volume_properties(physical_volumes_line)

lib/puppet/provider/volume_group/lvm.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ def self.get_volume_groups
2323
full_vgs_output = vgs.split("\n")
2424

2525
# Remove first line
26-
volume_groups = full_vgs_output.drop(1)
27-
28-
volume_groups
26+
full_vgs_output.drop(1)
2927
end
3028

3129
def self.get_logical_volume_properties(volume_groups_line)

0 commit comments

Comments
 (0)