(CONT-971) - Correct Style/RedundantArgument

Author: jordanbreen28

.rubocop_todo.yml

@@ -216,16 +216,6 @@ Style/OptionalBooleanParameter:
     - 'spec/spec_helper_acceptance_local.rb'
     - 'tests/beaker/lib/lvm_helper.rb'
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Methods.
-Style/RedundantArgument:
-  Exclude:
-    - 'lib/puppet/provider/logical_volume/lvm.rb'
-    - 'lib/puppet/provider/physical_volume/lvm.rb'
-    - 'lib/puppet/provider/volume_group/lvm.rb'
-    - 'lib/puppet_x/lvm/output.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantAssignment:

lib/puppet/provider/logical_volume/lvm.rb

@@ -49,7 +49,7 @@ def self.get_logical_volume_properties(logical_volumes_line)
     # LV      VG       Attr       LSize   Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
 
     # Split on spaces
-    output_array = logical_volumes_line.gsub(%r{\s+}m, ' ').strip.split(' ')
+    output_array = logical_volumes_line.gsub(%r{\s+}m, ' ').strip.split
 
     # Assign properties based on headers
     logical_volumes_properties[:ensure]       = :present

lib/puppet/provider/physical_volume/lvm.rb

@@ -65,7 +65,7 @@ def self.get_physical_volume_properties(physical_volumes_line)
     # PV         VG       Fmt  Attr PSize  PFree
 
     # Split on spaces
-    output_array = physical_volumes_line.gsub(%r{\s+}m, ' ').strip.split(' ')
+    output_array = physical_volumes_line.gsub(%r{\s+}m, ' ').strip.split
 
     # Assign properties based on headers
     # Just doing name for now...

lib/puppet/provider/volume_group/lvm.rb

@@ -35,7 +35,7 @@ def self.get_logical_volume_properties(volume_groups_line)
     # VG       #PV #LV #SN Attr   VSize  VFree
 
     # Split on spaces
-    output_array = volume_groups_line.gsub(%r{\s+}m, ' ').strip.split(' ')
+    output_array = volume_groups_line.gsub(%r{\s+}m, ' ').strip.split
 
     # Assign properties based on headers
     # Just doing name for now...

lib/puppet_x/lvm/output.rb

@@ -17,7 +17,7 @@ def self.parse(key, columns, data)
         key     = remove_prefix(key)
 
         data.split("\n").each do |line|
-          parsed_line = line.gsub(%r{\s+}, ' ').strip.split(' ')
+          parsed_line = line.gsub(%r{\s+}, ' ').strip.split
           values      = columns.zip(parsed_line).to_h
           current_key = values[key]
           values.delete(key)