chore: remove unused rust_wasm_component_macro rule and dead code #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove incomplete/unused macro-based WIT binding approach: - rust_wasm_component_macro.bzl: Never fully implemented, fails for symmetric mode, no targets used this rule - examples/macro_example/: BUILD.bazel never compiled lib.rs with generate!() macro - only had rust_binary for host app - examples/oci_publishing/src/: Unused since BUILD.bazel uses alias to //examples/basic:hello_component The rust_wasm_component_bindgen rule covers all commonly-used generate!() macro options (with_mappings, additional_derives, ownership, async_interfaces, generate_all) with an options escape hatch for edge cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
avrabe
force-pushed
the
cleanup/remove-dead-macro-code
branch
from
5522d08 to
3960f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rust_wasm_component_macrorule (never fully implemented, fails for symmetric mode)examples/macro_example/directory (BUILD.bazel never compiled the lib.rs)examples/oci_publishing/src/directory (unused - BUILD uses alias to basic example)Context
Investigation of issue #46 revealed that:
rust_wasm_component_macrowas never used by any targetgenerate!()macro code were dead code - never actually compiledrust_wasm_component_bindgenalready covers all commonly-used macro optionsVerification
wit_bindgenrule supports:with_mappings,additional_derives,ownership,async_interfaces,generate_all,format_codeoptionsattribute provides escape hatch for edge cases (skip,raw_strings,features)bazel build //rust:defs.bzl //examples/oci_publishing:hello_oci_componentpasses